FEATURE: basic notation standard#2
Open
Segelzwerg wants to merge 72 commits into
Open
Conversation
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
ADD: ref anchor Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
READD: fail on warning Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
READD: fail on warning Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
This reverts commit c4118a9.
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
iTitus
reviewed
Oct 29, 2024
iTitus
reviewed
Nov 2, 2024
iTitus
reviewed
Nov 2, 2024
iTitus
reviewed
Nov 2, 2024
iTitus
reviewed
Nov 2, 2024
Comment on lines
+42
to
+52
| [[stack.card]] | ||
| suit="heart" | ||
| rank="A" | ||
| [[data.stack.card]] | ||
| suit="heart" | ||
| rank="K" | ||
|
|
||
| [[hands.player_1]] | ||
| [[hands.player_1.card]] | ||
| suit="heart" | ||
| rank="2" |
Contributor
There was a problem hiding this comment.
this toml is a little bit weird.
a table uses [...] while a table in an array uses [[...]].
Contributor
There was a problem hiding this comment.
check out this and the following paragraphs about tables and arrays of tables: https://toml.io/en/v1.0.0#array
Contributor
Author
There was a problem hiding this comment.
I was also thinking, that actually don't need the hands, right?
iTitus
reviewed
Nov 2, 2024
Comment on lines
+10
to
+24
| class Stack: | ||
| """A list of cards.""" | ||
|
|
||
| def __init__(self, cards: List[Card]): | ||
| """ | ||
| Construct a stack of cards. | ||
|
|
||
| :param cards: A list of cards. | ||
| """ | ||
| self._card_list: List[Card] = cards | ||
|
|
||
| def dumps(self) -> str: | ||
| """Return the stack as TOML string.""" | ||
| card_dump = {'cards': [card.dict() for card in self._card_list]} | ||
| return tomlkit.dumps({'stack': card_dump}) |
Contributor
There was a problem hiding this comment.
a stack class is not very pythonic, because this could just be a list.
the wrapping is nice for encapsulation though. so its fine i guess.
Contributor
There was a problem hiding this comment.
but why is the representation {stack={cards=[<card-list>]}} ? why wrap it two times?
it could just be written as an array of cards
Contributor
Author
There was a problem hiding this comment.
Yeah, I think I had something else in mind originally where I needed an array. I try to change to an array.
Co-authored-by: iTitus <iTitus@users.noreply.github.com>
Co-authored-by: iTitus <iTitus@users.noreply.github.com>
Co-authored-by: iTitus <iTitus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.